Conversation
Deploying www-ruby-lang-org with
|
| Latest commit: |
ac8aee3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0c2b4230.www-ruby-lang-org.pages.dev |
| Branch Preview URL: | https://add-css-ci-check.www-ruby-lang-org.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds automated CSS build verification to the CI pipeline as part of the redesign project. The changes ensure that the compiled CSS file stays in sync with the source files by checking it on every pull request.
- Added Node.js setup and CSS build check to the GitHub Actions CI workflow
- Removed
package-lock.jsonfrom.gitignoreto track npm dependencies - Added
package-lock.jsonwith Tailwind CSS and typography plugin dependencies
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds Node.js setup, npm dependency installation, and CSS build verification steps before Ruby setup |
.gitignore |
Removes package-lock.json from ignore list to track it in version control |
package-lock.json |
Adds complete dependency tree for Tailwind CSS v3.4.17 and @tailwindcss/typography v0.5.19 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/ci.yml
Outdated
| - name: Check CSS is up-to-date | ||
| run: | | ||
| npm run build-css | ||
| git diff --exit-code stylesheets/compiled.css || (echo "Error: compiled.css is out of date. Run 'npm run build-css' and commit the changes." && exit 1) |
There was a problem hiding this comment.
The error message could be improved for clarity. Currently it says "Error: compiled.css is out of date" but it would be more helpful to specify which file needs to be regenerated and how to do it locally. Consider making the message more actionable, for example: "The compiled CSS is out of date. Please run 'npm run build-css' locally and commit the updated stylesheets/compiled.css file."
Suggested change
| git diff --exit-code stylesheets/compiled.css || (echo "Error: compiled.css is out of date. Run 'npm run build-css' and commit the changes." && exit 1) | |
| git diff --exit-code stylesheets/compiled.css || (echo "Error: The compiled CSS is out of date. Please run 'npm run build-css' locally and commit the updated stylesheets/compiled.css file." && exit 1) |
Member
Author
|
I'm not sure why +.rounded{
+ border-radius: 0.25rem;
+}
+
.rounded-2xl{
border-radius: 1rem;
}
@@ -4567,6 +4571,10 @@ body:is(.dark *){
text-decoration-line: underline;
}
... |
hsbt
force-pushed
the
add-css-ci-check
branch
2 times, most recently
from
e672ba1 to
e3c5e42
Compare
- Add Node.js setup and npm ci to CI workflow - Verify compiled.css is up-to-date by rebuilding and checking for diffs - Add package-lock.json to lock dependency versions - Remove package-lock.json from .gitignore 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The compiled CSS is a build artifact that should be generated during CI and deployment, not tracked in version control. This eliminates merge conflicts and repository bloat from the 5,900-line generated file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Since compiled.css is no longer tracked in the repository, the CI needs to build it before running tests. Move the Node.js setup and CSS build steps before the test step. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The deployment workflow also needs to build CSS before Jekyll generates the site, since compiled.css is no longer in the repository. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Since compiled.css is no longer in the repository, rake build and rake serve need to generate it first. This also covers rake test which depends on build. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Node.js 20 reaches EOL on 2026-04-30. Switch to Node.js 22 LTS which is supported until 2027-04-30. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The linter scans all markdown files and fails on files inside node_modules. Exclude the directory like other non-content paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is remaining work of redesign project. We should check to css build every PRs.